Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to nodejs's native iterator API when napi-rs is ready #1533

Closed
2 tasks
suyanhanx opened this issue Mar 9, 2023 · 5 comments
Closed
2 tasks

migrate to nodejs's native iterator API when napi-rs is ready #1533

suyanhanx opened this issue Mar 9, 2023 · 5 comments

Comments

@suyanhanx
Copy link
Member

suyanhanx commented Mar 9, 2023

We rely heavily on napi-rs to implement our functions.

The following APIs are still in some sort of simulation and will be migrated to the native implementation when napi-rs is ready.

Also see #1525 (comment)

napi-rs side

@Xuanwo
Copy link
Member

Xuanwo commented Mar 9, 2023

Is there an issue on the napi-rs side? We can link to this page to let them know that we have a demand for this feature.

@suyanhanx
Copy link
Member Author

suyanhanx commented Mar 9, 2023

Updated with current napi-rs's RFC 3.0.

@Xuanwo Xuanwo changed the title migrate to nodejs's native API when napi-rs is ready migrate to nodejs's native iterator API when napi-rs is ready Mar 9, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Dec 19, 2023

list should return Vec<Entry> now. @suyanhanx, would you like to change the API of opendal-nodejs?

@suyanhanx
Copy link
Member Author

list should return Vec<Entry> now. @suyanhanx, would you like to change the API of opendal-nodejs?

I'll handle this.

@suyanhanx
Copy link
Member Author

Plan to implement the System.iterator on the js side. Close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants