From 5d0e456b472b57bfc8a5eee05924a57cb621f7a6 Mon Sep 17 00:00:00 2001 From: 67 <67@gd67.com> Date: Mon, 23 Oct 2023 17:06:10 +0800 Subject: [PATCH 1/2] [ISSUE #7491] metricsExporterType enum config support --- .../java/org/apache/rocketmq/common/ControllerConfig.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java b/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java index 1e9c80b2220..fceb10a44ad 100644 --- a/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java +++ b/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java @@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType metricsExporterType) { this.metricsExporterType = metricsExporterType; } + // support read from config file using org.apache.rocketmq.common.MixAll.properties2Object + public void setMetricsExporterType(String metricsExporterType) { + this.metricsExporterType = MetricsExporterType.valueOf(metricsExporterType); + } + public String getMetricsGrpcExporterTarget() { return metricsGrpcExporterTarget; } From 1d8c87453ccc79108a0f49c1089d8ca054d46cdb Mon Sep 17 00:00:00 2001 From: 67 <67@gd67.com> Date: Tue, 24 Oct 2023 14:40:21 +0800 Subject: [PATCH 2/2] re-trigger tests --- .../main/java/org/apache/rocketmq/common/ControllerConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java b/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java index fceb10a44ad..c25e30b2959 100644 --- a/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java +++ b/common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java @@ -209,7 +209,7 @@ public void setMetricsExporterType(MetricsExporterType metricsExporterType) { this.metricsExporterType = metricsExporterType; } - // support read from config file using org.apache.rocketmq.common.MixAll.properties2Object + // support read from config file using MixAll.properties2Object public void setMetricsExporterType(String metricsExporterType) { this.metricsExporterType = MetricsExporterType.valueOf(metricsExporterType); }