Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test case MySQLDataSourcePreparerTest #14246

Closed
terrymanu opened this issue Dec 22, 2021 · 3 comments · Fixed by #15203
Closed

Fix test case MySQLDataSourcePreparerTest #14246

terrymanu opened this issue Dec 22, 2021 · 3 comments · Fixed by #15203
Assignees
@ksankeerth
Labels
good first issue in: test
Milestone
5.1.0

Comments

@terrymanu
Copy link
Member

Some changes in #14243 and broken the test case MySQLDataSourcePreparerTest, please mock and fix it.
@terrymanu terrymanu added this to the 5.1.0 milestone Dec 22, 2021
@menghaoranss menghaoranss modified the milestones: 5.1.0, 5.1.1 Dec 28, 2021
@ksankeerth
Copy link
Contributor

I would like to work on this issue.

@strongduanmu
Copy link
Member

@shankeerthan-kasilingam Welcome, I will assign this issue to you.

@ksankeerth ksankeerth mentioned this issue Jan 30, 2022
Merged
@ksankeerth
Copy link
Contributor

@strongduanmu Could you please check the PR and let me know if any improvements or changes to be done?

@menghaoranss menghaoranss modified the milestones: 5.1.1, 5.1.0 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksankeerth ksankeerth

Labels
good first issue in: test
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fixes MySQLDataSourcePreparerTest ksankeerth/shardingsphere
4 participants
@terrymanu @strongduanmu @ksankeerth @menghaoranss