Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] TracingSegmentRunner made Junit @After annotation not work #12210

Closed
3 tasks done
JoeCqupt opened this issue May 11, 2024 · 0 comments
Closed
3 tasks done

[Bug] TracingSegmentRunner made Junit @After annotation not work #12210

JoeCqupt opened this issue May 11, 2024 · 0 comments
Assignees
@JoeCqupt
Labels
bug Something isn't working and you are sure it's a bug! java Java agent related test Test requirements about performance, feature or before release.
Milestone
Java - 9.3.0

Comments

@JoeCqupt
Copy link

JoeCqupt commented May 11, 2024 •
edited

Search before asking

  • I had searched in the issues and found no similar issues.

Apache SkyWalking Component

Java Agent (apache/skywalking-java)

What happened

TracingSegmentRunner override method withAfters made Junit @after annotation not work

What you expected to happen

make Junit @after annotation work well

How to reproduce

  • step1
    Randomly select a unit test with TracingSegmentRunner
    eg： SofaRpcConsumerInterceptorTest add code :
    @After
    public void after() {
        Assert.fail("after fail.");
    }
  • step2: run SofaRpcConsumerInterceptorTest

expect: all unit test fail
actual: all unit test success

Anything else

nothing

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
@JoeCqupt JoeCqupt added the bug Something isn't working and you are sure it's a bug! label May 11, 2024
@JoeCqupt JoeCqupt mentioned this issue May 11, 2024
Merged
4 tasks
@wu-sheng wu-sheng added this to the Java - 9.3.0 milestone May 11, 2024
@wu-sheng wu-sheng added test Test requirements about performance, feature or before release. java Java agent related labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeCqupt JoeCqupt

Labels
bug Something isn't working and you are sure it's a bug! java Java agent related test Test requirements about performance, feature or before release.
Projects
None yet
Milestone
Java - 9.3.0
Development

No branches or pull requests
2 participants
@wu-sheng @JoeCqupt