Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset modal doesn't work correctly in dev server mode #18655

Closed
3 tasks
villebro opened this issue Feb 10, 2022 · 1 comment
Closed
3 tasks

Dataset modal doesn't work correctly in dev server mode #18655

villebro opened this issue Feb 10, 2022 · 1 comment
Labels

Comments

@villebro
Copy link
Member

When running Superset in dev server mode (npm run dev-server), the dataset edit modal doesn't work properly. For instance, when I add a label to a column and save, the updated value isn't persisted in the dataset metadata. See the screen recording below:

dev-server.mp4

However, when running a production build (npm run build), the modal works correctly:

prod.build.mp4

How to reproduce the bug

  1. Go to Dataset list view and edit your favourite dataset
  2. Click on Columns and add a label to a column
  3. Save and reopen the dataset Column view
  4. Notice that the updated column label is no longer present on dev server mode, but works correctly on the prod build

Expected results

Dataset should update correctly in both dev-server and build mode

Actual results

Dataset doesn't update correctly in dev-server mode

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

(please complete the following information):

  • browser type and version:
  • superset version: superset version
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@zhaoyongjie
Copy link
Member

closed by PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants