From cdbc23b6f95d6358fa72a45344db87ed5124322f Mon Sep 17 00:00:00 2001 From: stephenLYZ <750188453@qq.com> Date: Thu, 10 Feb 2022 17:15:19 +0800 Subject: [PATCH 1/3] fix: dataset modal in dev mode --- cache/dee95f0d5b78f9038514e10939609bc2 | Bin 0 -> 533 bytes superset-frontend/webpack.config.js | 5 +++++ 2 files changed, 5 insertions(+) create mode 100644 cache/dee95f0d5b78f9038514e10939609bc2 diff --git a/cache/dee95f0d5b78f9038514e10939609bc2 b/cache/dee95f0d5b78f9038514e10939609bc2 new file mode 100644 index 0000000000000000000000000000000000000000..01f7717f333720ecd2bf35c2ae7ed3918d5489c0 GIT binary patch literal 533 zcmXw0%W4}z5R^j$FHaBxC_MNkfA5DHiESyQ<~0TE+Dp> z*uYu(0!40#p&m;21>(2^XT24(Uft`dOd{TDRgd}sjzTA!LRIG6+)`@HS~!!ASH2d? ykV(+@P}YDdWRfqt(H}3-(?%^C(#$oox}JMAK~$44ziBUwlftyfvWnxFm;V7lmb>%- literal 0 HcmV?d00001 diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js index 55f0122ad20a..a7c668989293 100644 --- a/superset-frontend/webpack.config.js +++ b/superset-frontend/webpack.config.js @@ -344,6 +344,11 @@ const config = { ], use: [babelLoader], }, + { + test: /\.js$/, + include: /node_modules\/react-dom/, + use: ['react-hot-loader/webpack'], + }, { test: /\.css$/, include: [APP_DIR, /superset-ui.+\/src/], From c762ad3a06085b897304770e5f15c310dfb49194 Mon Sep 17 00:00:00 2001 From: stephenLYZ <750188453@qq.com> Date: Thu, 10 Feb 2022 17:35:03 +0800 Subject: [PATCH 2/3] remove cache --- cache/dee95f0d5b78f9038514e10939609bc2 | Bin 533 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 cache/dee95f0d5b78f9038514e10939609bc2 diff --git a/cache/dee95f0d5b78f9038514e10939609bc2 b/cache/dee95f0d5b78f9038514e10939609bc2 deleted file mode 100644 index 01f7717f333720ecd2bf35c2ae7ed3918d5489c0..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 533 zcmXw0%W4}z5R^j$FHaBxC_MNkfA5DHiESyQ<~0TE+Dp> z*uYu(0!40#p&m;21>(2^XT24(Uft`dOd{TDRgd}sjzTA!LRIG6+)`@HS~!!ASH2d? ykV(+@P}YDdWRfqt(H}3-(?%^C(#$oox}JMAK~$44ziBUwlftyfvWnxFm;V7lmb>%- From bdceb5ab35b40e6470cc02be2c2828635f56321c Mon Sep 17 00:00:00 2001 From: stephenLYZ <750188453@qq.com> Date: Thu, 10 Feb 2022 17:53:47 +0800 Subject: [PATCH 3/3] add comment --- superset-frontend/webpack.config.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js index a7c668989293..06f6825fa9fd 100644 --- a/superset-frontend/webpack.config.js +++ b/superset-frontend/webpack.config.js @@ -344,6 +344,9 @@ const config = { ], use: [babelLoader], }, + // react-hot-loader use "ProxyFacade", which is a wrapper for react Component + // see https://github.com/gaearon/react-hot-loader/issues/1311 + // TODO: refactor recurseReactClone { test: /\.js$/, include: /node_modules\/react-dom/,