Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event handles with VC_EVENT_ERROR but not VC_EVENT_EOS #11358

Closed
cmcfarlen opened this issue May 15, 2024 · 2 comments
Closed

Event handles with VC_EVENT_ERROR but not VC_EVENT_EOS #11358

cmcfarlen opened this issue May 15, 2024 · 2 comments

Comments

@cmcfarlen
Copy link
Contributor

While reviewing #11346, I went through and found other places where the EOS event was not handled but ERROR was:

src/iocore/net/QUICNextProtocolAccept.cc|44 col 8| case VC_EVENT_ERROR:
src/proxy/http/HttpSM.cc|1232 col 8| case VC_EVENT_ERROR:
src/proxy/http/HttpSM.cc|1808 col 8| case VC_EVENT_ERROR:
src/proxy/Transform.cc|634 col 10| case VC_EVENT_ERROR:
src/proxy/Transform.cc|793 col 10| case VC_EVENT_ERROR:

I wonder, should we add EOS to these switch statements as well?

@maskit
Copy link
Member

maskit commented May 15, 2024

I'm not sure whether QUICNextProtocolAccept.cc receives EOS, but we can add it.

Is the list complete? I wonder why SSLNextProtocolAccept.cc isn't on the list.

@cmcfarlen
Copy link
Contributor Author

Its likely not complete, just me staring at the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants