Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken when upgrade chart.js from 2.9.3 to 2.9.4 #657

Closed
BangNguyen1992 opened this issue Nov 5, 2020 · 2 comments
Closed

Broken when upgrade chart.js from 2.9.3 to 2.9.4 #657

BangNguyen1992 opened this issue Nov 5, 2020 · 2 comments

Comments

@BangNguyen1992
Copy link

Expected Behavior

Actual Behavior

After I upgrade chart.js to 2.9.4, some configs in the tick option don't work anymore, it seems to get overwritten by chartjs options

For example:

ticks: {
    callback: (value, index, values) => `£ ${value}`,
},

return the value only, it doesnt include the £.

Environment

  • vue.js version: 2.6.12
  • vue-chart.js version: 3.5.1
  • chart.js version: 2.9.4
  • npm version: 6.12.1
@apertureless
Copy link
Owner

Well the options get just passed to chart.js
Have you checked if the callback maybe changed in that chart.js version?

Not much I can do here.

@simonbrunel
Copy link

@apertureless FYI, I just found out that chartjs/Chart.js#7918 introduced a breaking change for reactive chart config or config containing reactive objects. Once merged, reactive objects are not anymore enumerable thus can't be iterated (Object.keys() returning an empty array). This can break some Vue.js integrations, such as the datalabels plugin Vuepress docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants