Add Chart.js 3.0 support #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangreen
requested changes
Feb 17, 2022
There was a problem hiding this comment.
- Need to add
sideEffects: falseinto package.json https://github.com/reactchartjs/react-chartjs-2/blob/master/package.json#L15 - Please add size-limit to test tree-shaking https://github.com/reactchartjs/react-chartjs-2/blob/master/.size-limit#L11
dangreen
requested changes
Feb 18, 2022
thabarbados
force-pushed
the
add-chartjs3-support
branch
from
566848b
to
f51c995
Compare
dangreen
requested changes
Feb 21, 2022
.github/workflows/checks.yml
Outdated
Comment on lines
25
to
31
| - name: Install dependencies | ||
| run: pnpm install | ||
| - name: Check size | ||
| uses: andresz1/size-limit-action@v1 | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| skip_step: install |
There was a problem hiding this comment.
Suggested change
| - name: Install dependencies | |
| run: pnpm install | |
| - name: Check size | |
| uses: andresz1/size-limit-action@v1 | |
| with: | |
| github_token: ${{ secrets.GITHUB_TOKEN }} | |
| skip_step: install | |
| - name: Check size | |
| uses: andresz1/size-limit-action@master | |
| with: | |
| github_token: ${{ secrets.GITHUB_TOKEN }} |
code from master has pnpm support
There was a problem hiding this comment.
@thabarbados look at the suggestion carefully
There was a problem hiding this comment.
@dangreen sorry, fixed
thabarbados
force-pushed
the
add-chartjs3-support
branch
from
bfd495c
to
ceec67b
Compare
dangreen
approved these changes
Feb 21, 2022
dangreen
pushed a commit
that referenced
this pull request
Feb 21, 2022
BREAKING CHANGE: upgrade to Chart.js 3.0
|
Great to see progress regarding Chartjs3 support! Do you have an ETA for a new release? |
|
@aarbakkeinnovation 1-3 weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or Enhancement?
Add Chart.js 3.0 support
Environment