fix(legacy-charts): fix render multiple charts at one page #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
dangreen
requested changes
Apr 7, 2022
legacy/src/Charts.js
Outdated
| export function generateChart(chartId, chartType, chartController) { | ||
| let _chart = null | ||
| let _store = null |
There was a problem hiding this comment.
it looks like "ref", so then maybe just
let _chartRef = { current: null }
...
_chartRef.current
?
There was a problem hiding this comment.
@dangreen, I checked, and your solution doesn't fix this bug.
There was a problem hiding this comment.
ok, here just let _chartRef = null
_store = new ComponentStore() -> _chartRef = { current: null }
_store.setComponentChart(...) -> _chartRef.current = ...
etc
There was a problem hiding this comment.
It works. I used it.
thabarbados
force-pushed
the
fix-multiple-legacy
branch
from
835e8f8
to
feb93d7
Compare
dangreen
requested changes
Apr 7, 2022
legacy/src/Charts.js
Outdated
Comment on lines
86
to
88
| _chartRef !== null && | ||
| 'current' in _chartRef && | ||
| _chartRef.current !== null |
There was a problem hiding this comment.
Suggested change
| _chartRef !== null && | |
| 'current' in _chartRef && | |
| _chartRef.current !== null | |
| _chartRef?.current |
?
legacy/src/Charts.js
Outdated
Comment on lines
103
to
104
| _chartRef !== null && | ||
| 'current' in _chartRef |
dangreen
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or Enhancement?
fix the error, when multiple charts can't render on one page
from issues #800 #801
Environment