fix(legacy-charts): tune chartoptions type check #821
Conversation
size-limit report 📦
|
| @@ -74,6 +74,7 @@ export function generateChart(chartId, chartType, chartController) { | |||
| computed: { | |||
| hasAnnotationPlugin() { | |||
There was a problem hiding this comment.
| hasAnnotationPlugin() { | |
| hasAnnotationPlugin() { | |
| return this.chartOptions?.plugins?.hasOwnProperty(ANNOTATION_PLUGIN_KEY) |
maybe better like that?
There was a problem hiding this comment.
@dangreen Do not access Object.prototype method 'hasOwnProperty' from target object.
There was a problem hiding this comment.
Reflect.hasOwnProperty(this.chartOptions?.plugins, ANNOTATION_PLUGIN_KEY)
There was a problem hiding this comment.
@dangreen has the same error((
There was a problem hiding this comment.
const plugins = this.chartOptions?.plugins
return plugins && Reflect.has(plugins, ANNOTATION_PLUGIN_KEY)There was a problem hiding this comment.
@dangreen has Vue error in build version[Vue warn]: Property or method "chartOptions" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.
There was a problem hiding this comment.
@thabarbados ok. please find short variant of current code, cause current variant is too long
There was a problem hiding this comment.
@dangreen fixed
thabarbados
force-pushed
the
fix-type-check
branch
from
a88e6c2
to
e766051
Compare
thabarbados
force-pushed
the
fix-type-check
branch
from
e766051
to
855f0ba
Compare
legacy/src/Charts.js
Outdated
| const pluginSettings = | ||
| this.chartOptions?.plugins?.[ANNOTATION_PLUGIN_KEY] | ||
|
|
||
| return pluginSettings !== undefined |
There was a problem hiding this comment.
| return pluginSettings !== undefined | |
| return typeof pluginSettings !== 'undefined' |
There was a problem hiding this comment.
@dangreen Used this option. I don't like Boolean)
legacy/src/Charts.js
Outdated
| const pluginSettings = | ||
| this.chartOptions?.plugins?.[ANNOTATION_PLUGIN_KEY] | ||
|
|
||
| return pluginSettings !== undefined |
There was a problem hiding this comment.
or just
| const pluginSettings = | |
| this.chartOptions?.plugins?.[ANNOTATION_PLUGIN_KEY] | |
| return pluginSettings !== undefined | |
| return Boolen(this.chartOptions?.plugins?.[ANNOTATION_PLUGIN_KEY]) |
thabarbados
force-pushed
the
fix-type-check
branch
from
855f0ba
to
22a5f4a
Compare
Fix or Enhancement?
tune legacy charts options type check
Environment