Legacy multiple annotations #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle multiple instances of a `vue-chartjs` wrapper component when the annotations plugin is in use
|
CI Test failures seem unrelated to my changes |
|
@kidGodzilla Hi. Thank you for the PR! Please pull changes from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or Enhancement?
Resolves #909 – Multiple instances of a chart cannot be rendered at once if using the Annotations plugin
Extends the
_chartRefobject to handle multiple instances ofvue-chartjswrapper components, in Vue 2, when the annotations plugin is present. Assigns a unique, random ID to each one.Sandboxes
Reproduces the issue with annotation plugin (multiple instances): https://codesandbox.io/s/practical-bas-2irrtp
Fixes the issue with updated compiled
vue-chartjslegacy component: https://codesandbox.io/s/twilight-feather-ymgud6Feel free to suggest improvements. I believe most of #818 could be factored out to treat this state management the same, even when the annotations plugin is not present, removing the computed property & $data._chart.
Environment