Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallthrough props to canvas #955

Merged
merged 1 commit into from Dec 1, 2022
Merged

feat: fallthrough props to canvas #955

merged 1 commit into from Dec 1, 2022

Conversation

dangreen
Copy link
Collaborator

@dangreen dangreen commented Dec 1, 2022

fallthrough non-chart props to canvas, chart props were renamed

BREAKING CHANGE: div wrapper was removed, chartData prop was renamed to data, chartOptions prop was renamed to options, generateChart was renamed to createTypedChart

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.cjs 1.15 KB (-8.69% 🔽) 23 ms (-8.69% 🔽) 32 ms (+151.24% 🔺) 55 ms
dist/index.js 1.03 KB (-9.63% 🔽) 21 ms (-9.63% 🔽) 22 ms (+143.56% 🔺) 43 ms

@dangreen dangreen force-pushed the feat-fallthrough-props branch 2 times, most recently from 7dba887 to d349ce1 Compare December 1, 2022 12:23
fallthrough non-chart props to canvas, chart props were renamed

BREAKING CHANGE: div wrapper was removed, `chartData` prop was renamed to `data`, `chartOptions`
prop was renamed to `options`, `generateChart` was renamed to `createTypedChart`
@dangreen dangreen merged commit 6675cb0 into main Dec 1, 2022
@dangreen dangreen deleted the feat-fallthrough-props branch December 1, 2022 12:30
@sumimakito sumimakito mentioned this pull request Dec 5, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant