Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-hour matching error #225

Open
percevalw opened this issue Nov 28, 2023 · 0 comments
Open

Full-hour matching error #225

percevalw opened this issue Nov 28, 2023 · 0 comments

Comments

@percevalw
Copy link
Member

Description

Cc @paul-bssr, thank you for reporting this.
Full hours are not correctly matched (time is not part of the matched span)

How to reproduce the bug

import edsnlp

nlp = edsnlp.blank('eds')
nlp.add_pipe('eds.normalizer')
nlp.add_pipe('eds.sentences')
nlp.add_pipe('eds.dates')

assert str(nlp("17/10/2023 18:37").spans['dates'][0]) == "17/10/2023 18:37"
assert str(nlp("17/10/2023 18:00").spans['dates'][0]) == "17/10/2023 18:00"   # Fails here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant