Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history prop is deprecated and will be removed in V5 #533

Open
adguernier opened this issue Mar 6, 2024 · 1 comment
Open

history prop is deprecated and will be removed in V5 #533

adguernier opened this issue Mar 6, 2024 · 1 comment
Labels
bug enhancement

Comments

@adguernier
Copy link
Contributor

Description
<AdminGuesser> uses the history prop which is deprecated since React-admin v4.
Additionally, this prop will be removed in React-admin V5.

Possible Solution
Remove this prop and let users choose the history component they need
@adguernier adguernier added the bug label Mar 6, 2024
@PawelSuwinski
Copy link
Contributor

PawelSuwinski commented Apr 9, 2024 •
edited

Partially resolved by #537 .

TODO:

  • remove history prop type
  • add router prop ( router: RouterEl = BrowserRouter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PawelSuwinski @adguernier