From c083af3461a926ea68837f216eacc67ca43a6fc3 Mon Sep 17 00:00:00 2001
From: JacquesDurand <59364973+JacquesDurand@users.noreply.github.com>
Date: Thu, 25 Apr 2024 17:51:36 +0200
Subject: [PATCH] fix(metadata): allow extracting routeName from XML config
 (#6329)

---
 src/Metadata/Extractor/XmlResourceExtractor.php   | 1 +
 src/Metadata/Extractor/schema/resources.xsd       | 1 +
 src/Metadata/Tests/Extractor/XmlExtractorTest.php | 2 ++
 src/Metadata/Tests/Extractor/xml/valid.xml        | 2 +-
 4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/Metadata/Extractor/XmlResourceExtractor.php b/src/Metadata/Extractor/XmlResourceExtractor.php
index bdb22f5304d..f4ae228d771 100644
--- a/src/Metadata/Extractor/XmlResourceExtractor.php
+++ b/src/Metadata/Extractor/XmlResourceExtractor.php
@@ -404,6 +404,7 @@ private function buildOperations(\SimpleXMLElement $resource, array $root): ?arr
                 'queryParameterValidate' => $this->phpize($operation, 'queryParameterValidate', 'bool'),
                 'priority' => $this->phpize($operation, 'priority', 'integer'),
                 'name' => $this->phpize($operation, 'name', 'string'),
+                'routeName' => $this->phpize($operation, 'routeName', 'string'),
             ]);
         }
 
diff --git a/src/Metadata/Extractor/schema/resources.xsd b/src/Metadata/Extractor/schema/resources.xsd
index 1d5f4998e66..6c1cc8526b6 100644
--- a/src/Metadata/Extractor/schema/resources.xsd
+++ b/src/Metadata/Extractor/schema/resources.xsd
@@ -48,6 +48,7 @@
         <xsd:attribute type="xsd:positiveInteger" name="priority"/>
         <xsd:attribute type="xsd:string" name="name"/>
         <xsd:attribute type="xsd:string" name="itemUriTemplate"/>
+        <xsd:attribute type="xsd:string" name="routeName"/>
     </xsd:complexType>
 
     <xsd:complexType name="graphQlOperations">
diff --git a/src/Metadata/Tests/Extractor/XmlExtractorTest.php b/src/Metadata/Tests/Extractor/XmlExtractorTest.php
index 2b0fd95549a..eb3b552395e 100644
--- a/src/Metadata/Tests/Extractor/XmlExtractorTest.php
+++ b/src/Metadata/Tests/Extractor/XmlExtractorTest.php
@@ -273,6 +273,7 @@ public function testValidXML(): void
                             'itemUriTemplate' => null,
                             'stateOptions' => null,
                             'links' => null,
+                            'routeName' => 'custom_route_name',
                         ],
                         [
                             'name' => null,
@@ -373,6 +374,7 @@ public function testValidXML(): void
                             'provider' => null,
                             'stateOptions' => null,
                             'links' => null,
+                            'routeName' => null,
                         ],
                     ],
                     'graphQlOperations' => null,
diff --git a/src/Metadata/Tests/Extractor/xml/valid.xml b/src/Metadata/Tests/Extractor/xml/valid.xml
index d1ef2e81d1e..6942c6a2ce3 100644
--- a/src/Metadata/Tests/Extractor/xml/valid.xml
+++ b/src/Metadata/Tests/Extractor/xml/valid.xml
@@ -95,7 +95,7 @@
         </exceptionToStatus>
 
         <operations>
-            <operation class="ApiPlatform\Metadata\GetCollection" name="custom_operation_name"/>
+            <operation class="ApiPlatform\Metadata\GetCollection" name="custom_operation_name" routeName="custom_route_name"/>
             <operation class="ApiPlatform\Metadata\Get" uriTemplate="/users/{userId}/comments/{id}{._format}">
                 <uriVariables>
                     <uriVariable parameterName="userId" fromClass="ApiPlatform\Metadata\Tests\Fixtures\ApiResource\User" fromProperty="author"/>