Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reference issues since minor release 2.1.0 #1361

Closed
TiMESPLiNTER opened this issue Sep 12, 2017 · 4 comments
Closed

Can't reference issues since minor release 2.1.0 #1361

TiMESPLiNTER opened this issue Sep 12, 2017 · 4 comments

Comments

@TiMESPLiNTER
Copy link

TiMESPLiNTER commented Sep 12, 2017

We used to reference definitions of entities with the schema: {entity_name}_{hash} for the swagger doc:

src/AppBundle/Resources/config/api_resources/resources.yml

Acme\Api\Model\Image:
    itemOperations:
        get:
             method: "GET"
             path: "/path/{id}"
             swagger_context:
                 parameters:
                  - name: "id"
                    required: true
                    type: "string"
                    in: "path"
                    description: "ID of the image resource."
                 responses:
                     200:
                        description: "Image returned"
                        schema:
                            $ref: "#/definitions/Image_45f28e6683c923d629dea6466d6b7259"

this worked in 2.0.x. But since 2.1.0 the definitions are gone.

Don't know if we used an undocumented "feature" (couldn't find it in the documentation) or if this is a bug.

@soyuka
Copy link
Member

soyuka commented Sep 12, 2017

Names have been reviewed see #1207 (I think this is it)

@TiMESPLiNTER
Copy link
Author

@soyuka perfect! Thanks for your help. 😃

@dunglas
Copy link
Member

dunglas commented Sep 12, 2017

It would be nice to add this to the changelog.

@soyuka
Copy link
Member

soyuka commented Sep 12, 2017

Reopening til changelog is merged

@soyuka soyuka reopened this Sep 12, 2017
soyuka added a commit that referenced this issue Sep 12, 2017
Add swagger definition keys to changelog fix #1361
@soyuka soyuka closed this as completed Sep 12, 2017
hoangnd25 pushed a commit to hoangnd25/core that referenced this issue Feb 23, 2018
hoangnd25 pushed a commit to hoangnd25/core that referenced this issue Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants