Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions #119

Closed
Siegrift opened this issue Nov 27, 2023 · 5 comments
Closed

Update release instructions #119

Siegrift opened this issue Nov 27, 2023 · 5 comments

Comments

@Siegrift
Copy link
Contributor

Siegrift commented Nov 27, 2023

See: #118 (comment)

The instructions are almost correct, but only a few people have access to push directly to main so there should be a workaround to create a PR. Note that merging these versioning PRs should be done using Rebase and Merge strategy to prevent commit hash changing and breaking the git tag (note: it always changes when you use squash and merge).

The release instructions should also mention a new docs release (provided its a major/minor change).

@dcroote dcroote mentioned this issue Nov 28, 2023
@dcroote
Copy link
Contributor

dcroote commented Nov 28, 2023

This could also be fixed by migrating to pnpm and using CD via pnpm publish --provenance per pnpm/pnpm#6435. I'd actually prefer this route.

@Siegrift
Copy link
Contributor Author

This could also be fixed by migrating to pnpm and using CD

I think that would be a nice to have given the additional work and the amount of releases we do.

merging these versioning PRs should be done using Rebase and Merge strategy to prevent commit hash changing and breaking the git tag

For visibility, I was wrong in the initial comment regarding rebase and merge strategy. In this followup comment you pointed out that that breaks the git tag as well.

I think we can just keep pushing directly to main branch and in a special case people can open a PR and re-tag manually or ask for push to main access.

@dcroote
Copy link
Contributor

dcroote commented Nov 29, 2023

I think that would be a nice to have

Agreed, created #122 with the "enhancement" label

I think we can just keep pushing directly to main branch and in a special case people can open a PR and re-tag manually or ask for push to main access.

Agreed

@Siegrift
Copy link
Contributor Author

Also mention to run yarn before building the package to make sure dependencies are fresh. See https://github.com/api3dao/airnode/pull/1914/files#r1410222824

@dcroote
Copy link
Contributor

dcroote commented Mar 20, 2024

I think we can say this has been closed by #137 since the README is now updated with instructions using the GitHub Actions publishing with provenance flow.

@dcroote dcroote closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants