New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint-staged requires at least version 8.12.0 of Node #233
Comments
Wow, limiting Node versions to minor numbers? That's quite unexpected, I'd assume tools would be more benevolent in this. Is there a good reason why they do so? I'd be hesitant to allow only for certain minor versions of Node 8.x.x, that would need to propagate to Dredd and other things as well. Also we support anything with 8 as a major now, so it would be a breaking change. Perhaps we could specify that even though Gavel works with 8 and is tested with 8, for development 8.12.0 is needed, but that's just counter-intuitive. |
This is the PR where they introduced it lint-staged/lint-staged#646. The 💩 falls down from sindresorhus/execa#319. @artem-zakharchenko Is the message produced by I think there's no reason to pin Gavel's requirement to 8.12.0 as Gavel itself runs on any Node 8. And contributors will probably opt for Node 10 or 12 anyway, what do you think? |
Also I don't know if I want to pin lint-staged as we'd have to remember to re-enable dependabot again on it once we drop Node 8 and we'd lose security fixes. |
The message produced terminates the process, forbidding to perform a commit (terminates a husky process for One solution would be to downgrade to I am against changing the version of Node required by Gavel, as it alters the meaning of the required version (the one needed to operate, not to develop). |
What do you think about recommending to develop Gavel with Node 10? |
If we lock the Node version with |
I see |
Addressed in 73b7a95 as it blocks the work on the pull request. |
🎉 This issue has been resolved in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
When performing a commit, a pre-commit hook from Husky executes the
lint-staged
command, which produces the following error:This behavior is reproducible on both
9.0.1
and9.0.2
versions oflint-staged
.Perhaps, we should consider setting the NodeJS version to at least
8.12.0
, or revert to the version oflint-staged
that does not have such limitation.The text was updated successfully, but these errors were encountered: