Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] restore SDL download #4046

Merged
merged 4 commits into from Apr 19, 2022
Merged

[2.x] restore SDL download #4046

merged 4 commits into from Apr 19, 2022

Conversation

martinbonnin
Copy link
Contributor

See #4040

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 3321ed0
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/625eb32e1ce6680008c46921

@martinbonnin
Copy link
Contributor Author

Ouch, we've hit https://youtrack.jetbrains.com/issue/KT-47333 meaning we need to either:

  • upgrade Kotlin
  • or downgrade XCode

to continue building...

I'll make a quick attempt at updating Kotlin. Let's see what happens

@martinbonnin
Copy link
Contributor Author

The build did pass with Kotlin 1.5.31. No luck on getting the doc previews though... I'd say we can live without the previews in the 2.x branch?

@BoD
Copy link
Contributor

BoD commented Apr 19, 2022

The build did pass with Kotlin 1.5.31. No luck on getting the doc previews though... I'd say we can live without the previews in the 2.x branch?

Yes 👍 for me

@martinbonnin martinbonnin merged commit e8b8761 into release-2.x Apr 19, 2022
@martinbonnin martinbonnin deleted the sdl-download branch April 19, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants