Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo v2 Kotlin 1.7.0 incompatibility #4183

Closed
remcomokveld opened this issue Jun 13, 2022 · 5 comments
Closed

Apollo v2 Kotlin 1.7.0 incompatibility #4183

remcomokveld opened this issue Jun 13, 2022 · 5 comments

Comments

@remcomokveld
Copy link

remcomokveld commented Jun 13, 2022

Summary
The v2 com.apollographql.apollo Gradle fails to configure the project after updating Kotlin to 1.7.0.

Version
2.5.11

Description
I completely understand if you don't want to invest any additional time in the 2.x releases so I'm also happy to dig deeper and put up a PR to fix this, but it would be nice to not force users of Apollo 2.x to stick to Kotlin 1.6 until they've migrated to 1.7.

TBH I have not yet looked at the upgrade path for 3.x so if there is strong recommedation to do that instead, also happy to do that. But if the fix for 2.x is simple I think that would be nice for anyone else that's not fully up-to-date on their apollo updates.

I created a bare mimimum sample repository here. https://github.com/remcomokveld/apollo-kotlin-repro

@BoD
Copy link
Contributor

BoD commented Jun 13, 2022

Hi! Thank you for reporting this, and the repro project!

Indeed we recommend moving to to 3.x, however if a fix is possible, a new release of 2.x is not out of the question. If you want to investigate you are welcome!

@martinbonnin
Copy link
Contributor

+1 to doing a maintenance release there.

@remcomokveld also the upgrade guide to 3.x is there: https://www.apollographql.com/docs/kotlin/migration/3.0.

@BoD
Copy link
Contributor

BoD commented Jun 13, 2022

The issue was a signature change in the KotlinCompile task. A fix is in #4187, and we'll release a new 2.x version soon.

@remcomokveld
Copy link
Author

Thank you! 🙏

@BoD
Copy link
Contributor

BoD commented Jun 14, 2022

The fix is in v2.5.12 which was just released.

@BoD BoD closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants