Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to docs and examples #244

Open
1 task done
EddStrickland opened this issue Apr 9, 2020 · 3 comments
Open
1 task done

Update to docs and examples #244

EddStrickland opened this issue Apr 9, 2020 · 3 comments

Comments

@EddStrickland
Copy link

for the typescript example has errors within it. It's also using older syntax for react and class based component architecture.

My fork is to resolve those bugs and refactor it to work with functional based components.

Updated the example from NPM read me to use more functional code and also to resolve the errors which are now showing with the updated packages on the typescript code example:

can be reviewed here https://codesandbox.io/s/apollo-link-rest-typescript-example-6r9pp

if this is acceptable please feel free to add to the working version for the next release.

@fbartho
Copy link
Collaborator

fbartho commented Jan 5, 2022

Sorry I missed this. If this is still relevant, please advise!

@EddStrickland
Copy link
Author

Sorry I missed this. If this is still relevant, please advise!

I've not updated the packages since this was made however the code should still be valid and can be used within the readme if useful?

@EddStrickland
Copy link
Author

judging from the issues raised within your own code sandbox because of package entropy you'd need to update all the packages first to make your original work now, however this worked when submitted. I guess this means this project isn't being actively maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants