Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apollographql/apollo-server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: apollo-server@2.22.2
Choose a base ref
...
head repository: apollographql/apollo-server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: apollo-server@2.23.0
Choose a head ref

Commits on Mar 25, 2021

  1. Allow specifying context arguments with executeOperation (#4166)

    Add optional argument to `ApolloServer.executeOperation` allowing the caller to manually specify an argument to the `config` function analogous to that provided by integration packages.
    
    It is the caller's responsibility to figure out what should go in that argument and keep it up to date as they upgrade Apollo Server.
    
    Fixes #2886.
    
    Co-authored-by: David Glasser <glasser@davidglasser.net>
    chengcyber and glasser authored Mar 25, 2021
    Copy the full SHA
    a5c6bcd View commit details
  2. READMEs: ensure all npm install lines include graphql

    It's a peer dep so it doesn't get installed by default (on older npm at least).
    glasser committed Mar 25, 2021
    Copy the full SHA
    b82c431 View commit details
  3. Upgrade cors and @types/cors (#5062)

    The change to the code was necessary due to
    DefinitelyTyped/DefinitelyTyped#49130 which ironically
    was apparently submitted to support Apollo!
    
    Also remove unnecessary @types/cors dependency from apollo-server-koa.
    
    Fixes #5055.
    glasser authored Mar 25, 2021
    Copy the full SHA
    474a9f0 View commit details

Commits on Mar 26, 2021

  1. Release 2.22.0 (#5051)

    glasser authored Mar 26, 2021
    Copy the full SHA
    aea4796 View commit details
  2. Copy the full SHA
    318483b View commit details
  3. Copy the full SHA
    0ec7351 View commit details
  4. Ensure startup errors are redacted even the first time (#5064)

    This is a regression in #4981. If the server start process is begun implicitly
    by the execution of an operation (ensureStarted inside graphQLServerOptions) and
    startup throws, the log-and-redact logic wasn't being invoked.
    
    Note that this case doesn't usually happen in practice, because:
    - If you're using `apollo-server`, startup is begun in `listen()` before you can
      serve requests
    - If you're using a serverless framework integration, startup is begun in the
      constructor
    - If you're using a non-serverless framework integration, the function you call
      to connect it to your framework begins startup with `ensureStarting()`
    
    So mostly this just affects the case that you're running `executeOperation`
    without calling `start()` or `listen()`, or maybe you have your own custom
    framework integration that doesn't call `ensureStarting()`. But it's still worth
    missing.
    
    Add some tests of this behavior and fix some TypeScript issues in the test file.
    glasser authored Mar 26, 2021
    Copy the full SHA
    3ae2f5f View commit details
  5. Copy the full SHA
    9b582c1 View commit details

Commits on Mar 27, 2021

  1. chore(deps): update dependency ioredis to v4.24.5 (#5049)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot authored Mar 27, 2021
    Copy the full SHA
    8f54a69 View commit details

Commits on Mar 29, 2021

  1. chore(deps): pin dependency @josephg/resolvable to 1.0.0 (#5069)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot authored Mar 29, 2021
    Copy the full SHA
    569d8e6 View commit details
  2. Merge branch 'release-2.22.2' into main

    Resolved CHANGELOG.md conflicts
    glasser committed Mar 29, 2021
    Copy the full SHA
    2f27764 View commit details

Commits on Mar 30, 2021

  1. Update CODEOWNERS (#5063)

    - Remove a file that's not in the repo anymore
    - Switch docs to a more current list of users
    
    Co-authored-by: Jesse Rosenberger <git@jro.cc>
    glasser and abernix authored Mar 30, 2021
    Copy the full SHA
    1bb051f View commit details

Commits on Apr 3, 2021

  1. chore(deps): update dependency @types/supertest to v2.0.11 (#5081)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot authored Apr 3, 2021
    Copy the full SHA
    b0311c5 View commit details
  2. chore(deps): update dependency @types/ws to v7.4.1 (#5082)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot authored Apr 3, 2021
    Copy the full SHA
    973cfb4 View commit details
  3. chore(deps): update dependency ioredis to v4.25.0 (#5083)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot authored Apr 3, 2021
    Copy the full SHA
    2a49de8 View commit details

Commits on Apr 6, 2021

  1. apollo-servercache-redis: Allow Redis client to be injected (#5034)

    - Allow Redis client to be injected by using the `BaseRedisCache` class which contains the existing implementation logic without the client initialisation.
    - Removes duplication between `RedisCache` and `RedisClusterCache`
    - Fixes a bug where the result of delete is returned as a number, rather than a boolean. (Our TypeScript types have always declared that this function returns a boolean as `KeyValueCache.delete` should, but the actual implementation returned a number. This was not noticed because of the use of an `any` type.)
    
    In my opinion, `BaseRedisCache` should really be `RedisCache` and the existing `RedisCache` + `RedisCacheCluster` should either be renamed to identify that they are using the ioredis client, or removed and left for the consumer of the library to implement/ inject the client using this method. But this would obviously be a breaking change so maybe one to think about for the future?
    
    I've created an interface for the `RedisClient` rather than rely on the ioredis type as i do not believe apollo should be tied to the ioredis interface.
    
    Fixes #4871. Fixes #4870. Fixes #5006.
    adamnoakes authored Apr 6, 2021
    Copy the full SHA
    1a7f470 View commit details
  2. Copy the full SHA
    0a9a816 View commit details
  3. Merge pull request #5087 from apollographql/renovate/documentation-theme

    chore(deps): update dependency gatsby-theme-apollo-docs to v4.7.2
    Stephen Barlow authored Apr 6, 2021
    Copy the full SHA
    b6cb78a View commit details
  4. apollo-server-cache-redis: follow-up to #5034 (#5088)

    Add docs and changelog. As part of doing this, realize that the implementation
    in #5034 makes it annoying to inject a cluster client, so switch the new API to
    decide about get vs mget based on which kind of client is passed to the base
    class.
    glasser authored Apr 6, 2021
    Copy the full SHA
    df06a7c View commit details
  5. Fix formatResponse typings (#5089)

    This typing was added in #3431; it looks like we put the `| null` in the wrong
    place. Fortunately, a function that's OK with accepting a null argument and will
    never return null can still typecheck with the new type.
    
    Fixes #5009.
    glasser authored Apr 6, 2021
    Copy the full SHA
    ad4c3ac View commit details
  6. Copy the full SHA
    01dab00 View commit details

Commits on Apr 8, 2021

  1. apollo-server-core: use UserInputError for variable coercion errors (#…

    …5091)
    
    This particular error can be trivially triggered by clients, so it doesn't make
    sense to use `INTERNAL_SERVER_ERROR` for it. It seems like a good fit for
    `BAD_USER_INPUT`, which previously was only used if you explicitly throw a
    `UserInputError` in your app.
    
    Fixes #3498.
    glasser authored Apr 8, 2021
    Copy the full SHA
    e3be328 View commit details
  2. changelog header

    glasser committed Apr 8, 2021
    Copy the full SHA
    4d28b1e View commit details
  3. Release

     - apollo-datasource-rest@0.12.0-alpha.0
     - apollo-server-azure-functions@2.23.0-alpha.0
     - apollo-server-cache-redis@1.4.0-alpha.0
     - apollo-server-cloud-functions@2.23.0-alpha.0
     - apollo-server-cloudflare@2.23.0-alpha.0
     - apollo-server-core@2.23.0-alpha.0
     - apollo-server-errors@2.5.0-alpha.0
     - apollo-server-express@2.23.0-alpha.0
     - apollo-server-fastify@2.23.0-alpha.0
     - apollo-server-hapi@2.23.0-alpha.0
     - apollo-server-integration-testsuite@2.23.0-alpha.0
     - apollo-server-koa@2.23.0-alpha.0
     - apollo-server-lambda@2.23.0-alpha.0
     - apollo-server-micro@2.23.0-alpha.0
     - apollo-server-plugin-operation-registry@0.9.0-alpha.0
     - apollo-server-testing@2.23.0-alpha.0
     - apollo-server@2.23.0-alpha.0
    glasser committed Apr 8, 2021
    Copy the full SHA
    9d1cbd1 View commit details

Commits on Apr 9, 2021

  1. Copy the full SHA
    df7b604 View commit details
  2. Change clusterClient to noMgetClient

    If you totally swap out ioredis for a different implementation then maybe you can
    use mget with cluster (or maybe ioredis will support that some day), so using a
    more precise term makes sense.
    glasser committed Apr 9, 2021
    Copy the full SHA
    21f148e View commit details
  3. circle: bump orb version

    This changes us to run stuff in Node 12 which is required for the latest verdaccio.
    glasser authored Apr 9, 2021
    Copy the full SHA
    b91d697 View commit details
  4. Copy the full SHA
    f772ed6 View commit details
  5. apollo-server-lambda: Explicitly support payloadFormatVersion 2.0 (#5098

    )
    
    Fixes #5084.
    
    The sooner we get out of the business of understanding Lambda event formats, the
    better. But this fix should be good for now.
    glasser authored Apr 9, 2021
    Copy the full SHA
    751dbf0 View commit details
  6. Release

     - apollo-server-azure-functions@2.23.0-alpha.1
     - apollo-server-cache-redis@1.4.0-alpha.1
     - apollo-server-cloud-functions@2.23.0-alpha.1
     - apollo-server-cloudflare@2.23.0-alpha.1
     - apollo-server-core@2.23.0-alpha.1
     - apollo-server-express@2.23.0-alpha.1
     - apollo-server-fastify@2.23.0-alpha.1
     - apollo-server-hapi@2.23.0-alpha.1
     - apollo-server-integration-testsuite@2.23.0-alpha.1
     - apollo-server-koa@2.23.0-alpha.1
     - apollo-server-lambda@2.23.0-alpha.1
     - apollo-server-micro@2.23.0-alpha.1
     - apollo-server-testing@2.23.0-alpha.1
     - apollo-server@2.23.0-alpha.1
    glasser committed Apr 9, 2021
    Copy the full SHA
    3a369c3 View commit details
  7. Fix flaky websocket tests

    Even though this is going away in AS3, it's gotten really annoying. We can't
    just assume that adding one to a port gives a listenable port. Fortunately we
    can get the OS to choose a port for us. It was easier to make this fix by
    rewriting the test to be async.
    
    Fixes #5101
    glasser committed Apr 9, 2021
    Copy the full SHA
    980786a View commit details

Commits on Apr 14, 2021

  1. Release

     - apollo-datasource-rest@0.12.0
     - apollo-server-azure-functions@2.23.0
     - apollo-server-cache-redis@1.4.0
     - apollo-server-cloud-functions@2.23.0
     - apollo-server-cloudflare@2.23.0
     - apollo-server-core@2.23.0
     - apollo-server-errors@2.5.0
     - apollo-server-express@2.23.0
     - apollo-server-fastify@2.23.0
     - apollo-server-hapi@2.23.0
     - apollo-server-integration-testsuite@2.23.0
     - apollo-server-koa@2.23.0
     - apollo-server-lambda@2.23.0
     - apollo-server-micro@2.23.0
     - apollo-server-plugin-operation-registry@0.9.0
     - apollo-server-testing@2.23.0
     - apollo-server@2.23.0
    glasser committed Apr 14, 2021
    Copy the full SHA
    8a4cc58 View commit details
Loading