Comment in code is misleading or code is wrong for parsing query if its already AST

[jardakotesovec]

This is probably small catch - but maybe useful. Noticed that in here comment says if query is already an AST, don't parse or validate, but in fact it just skip the parsing step.

In our case it works as we want. Because we just want to do parse step outside of runHttpQuery to be able to read mutation name from it. But wanted to bring it up to make sure if it works as intended and the validation steps always happen there also in future.

[Piefayth]

See also: #722 - Our use case prefers it works as described, not as written.

[abernix]

We're working on providing techniques to control the exact behavior, which has been facilitated by the work done in #1795. For what it's worth, the confusing comment you'd referred to:

apollo-server/packages/apollo-server-core/src/runQuery.ts

Line 153 in 5b90120

// if query is already an AST, don't parse or validate

...has been removed!

[abernix]

We're working on providing techniques to control the exact behavior, which has been facilitated by the work done in #1795.

The confusing comment you'd referred to:

apollo-server/packages/apollo-server-core/src/runQuery.ts

Line 153 in 5b90120

// if query is already an AST, don't parse or validate

...has been removed, so I'll close this. Thanks for reporting this originally!