Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations not appearing in the "Deprecations" tab #84

Open
solher opened this issue May 20, 2021 · 3 comments
Open

Deprecations not appearing in the "Deprecations" tab #84

solher opened this issue May 20, 2021 · 3 comments

Comments

@solher
Copy link

solher commented May 20, 2021

Hi, I deprecated a field in my schema using the @deprecated directive and then I pushed it to Apollo Studio.

Now I see it in the SDL:

input SetInSeenlistInput {
	userInfo: UserInfo @deprecated(reason: "...")
}

It's even being displayed as deprecated in the changelog:

Screenshot 2021-05-20 at 19 35 53

But then when I'm going to the Deprecations tab of the Fields, I'm getting:

Screenshot 2021-05-20 at 19 39 49

Am I missing something? Thanks in advance 🙏

@timbotnik
Copy link
Contributor

👋 Thanks for the question. That does seem strange, would you mind opening a support conversation from inside Apollo Studio so we can inspect your specific situation?

Screen Shot 2021-05-21 at 10 44 31 am

@solher
Copy link
Author

solher commented May 21, 2021

Done. Thanks for the quick reply!
I'd have another quick question, is there a way to mark fields as deprecated while using introspection? I noticed that introspection removes the annotation so it gave me the feeling that the only way to deprecate fields is to submit the raw graphql schema file to Apollo Studio.

@timbotnik
Copy link
Contributor

I noticed you might be trying to deprecate input type fields, which has been a long-standing issue at the GraphQL specification level: graphql/graphql-spec#805. It looks like there is some recent progress and possibly still in-flight work on this in the graphql-js package which might be relevant.
graphql/graphql-js#2855
graphql/graphql-js#3048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants