Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Pink text in code tags is difficult to read #1133

Open
jglovier opened this issue Mar 31, 2021 · 4 comments
Open

Pink text in code tags is difficult to read #1133

jglovier opened this issue Mar 31, 2021 · 4 comments
Assignees
Labels

Comments

@jglovier
Copy link
Contributor

The pink text in the code tags looks really fun and adds personality to the docs design, but it's difficult to read. Especially in articles like the Federation error codes doc where much of the page copy is in this format.

I'm also sad to report that it fails WCAG accessibility for color contrast pretty hard.

And finally, the fact that it is a bright color could easily confuse readers to wonder if it is in fact also a link. 😕

I know it's not as fun, but i'd suggest we move to simply black (or Apollo SpaceKit's black-base value of #191C23).

We could use something a little bit more fun and still has better contrast (like indigo-dark, #3F20BA), but my concern here still is that using any color is going to signal that it's a link, which in fact it is not.

Any objections to a PR that would update the code snippets to black-base?

(Note: to clarify, I'm only suggesting updating the styling for inline code ticks at this point; I consider syntax highlighting in the code blocks a much different matter because they're not read like prose, and generally I think the pink is much more appropriate there)

@jglovier jglovier self-assigned this Mar 31, 2021
@jglovier
Copy link
Contributor Author

jglovier commented Mar 31, 2021

For comparison, here's pink vs black vs indigo:

pink-base black-base indigo-dark
image image image

@kuzmaMinin
Copy link

тесто

@kuzmaMinin
Copy link

ну вы блин даете

@kuzmaMinin
Copy link

это все надо удалять

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants