-
Notifications
You must be signed in to change notification settings - Fork 242
/
keyFieldsSelectInvalidType.test.ts
136 lines (120 loc) 路 3.54 KB
/
keyFieldsSelectInvalidType.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
import gql from 'graphql-tag';
import { composeServices } from '../../../compose';
import { keyFieldsSelectInvalidType as validateKeyFieldsSelectInvalidType } from '../';
import { graphqlErrorSerializer } from 'apollo-federation-integration-testsuite';
import { assertCompositionSuccess } from '../../../utils';
expect.addSnapshotSerializer(graphqlErrorSerializer);
describe('keyFieldsSelectInvalidType', () => {
it('returns no warnings with proper @key usage', () => {
const serviceA = {
// FIXME: add second key "upc" when duplicate directives are supported
// i.e. @key(fields: "sku") @key(fields: "upc")
typeDefs: gql`
type Product @key(fields: "sku") {
sku: String!
upc: String!
color: Color!
}
type Color {
id: ID!
value: String!
}
`,
name: 'serviceA',
};
const serviceB = {
typeDefs: gql`
extend type Product {
sku: String! @external
price: Int! @requires(fields: "sku")
}
`,
name: 'serviceB',
};
const serviceList = [serviceA, serviceB];
const compositionResult = composeServices(serviceList);
assertCompositionSuccess(compositionResult);
const { schema } = compositionResult;
const warnings = validateKeyFieldsSelectInvalidType({
schema,
serviceList,
});
expect(warnings).toHaveLength(0);
});
it('warns if @key references fields of an interface type', () => {
const serviceA = {
typeDefs: gql`
type Product @key(fields: "featuredItem") {
featuredItem: Node!
sku: String!
}
interface Node {
id: ID!
}
`,
name: 'serviceA',
};
const serviceB = {
typeDefs: gql`
extend type Product {
sku: String! @external
price: Int! @requires(fields: "sku")
}
`,
name: 'serviceB',
};
const serviceList = [serviceA, serviceB];
const compositionResult = composeServices(serviceList);
assertCompositionSuccess(compositionResult);
const { schema } = compositionResult;
const warnings = validateKeyFieldsSelectInvalidType({
schema,
serviceList,
});
expect(warnings).toMatchInlineSnapshot(`
Array [
Object {
"code": "KEY_FIELDS_SELECT_INVALID_TYPE",
"message": "[serviceA] Product -> A @key selects Product.featuredItem, which is an interface type. Keys cannot select interfaces.",
},
]
`);
});
it('warns if @key references fields of a union type', () => {
const serviceA = {
typeDefs: gql`
type Product @key(fields: "price") {
sku: String!
price: Numeric!
}
union Numeric = Float | Int
`,
name: 'serviceA',
};
const serviceB = {
typeDefs: gql`
extend type Product {
sku: String! @external
name: String!
}
`,
name: 'serviceB',
};
const serviceList = [serviceA, serviceB];
const compositionResult = composeServices(serviceList);
assertCompositionSuccess(compositionResult);
const { schema } = compositionResult;
const warnings = validateKeyFieldsSelectInvalidType({
schema,
serviceList,
});
expect(warnings).toMatchInlineSnapshot(`
Array [
Object {
"code": "KEY_FIELDS_SELECT_INVALID_TYPE",
"message": "[serviceA] Product -> A @key selects Product.price, which is a union type. Keys cannot select union types.",
},
]
`);
});
});