-
Notifications
You must be signed in to change notification settings - Fork 242
/
uniqueFieldDefinitionNames.test.ts
323 lines (298 loc) 路 7.91 KB
/
uniqueFieldDefinitionNames.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
import {
GraphQLSchema,
specifiedDirectives,
DocumentNode,
Kind,
extendSchema,
} from 'graphql';
import { validateSDL } from 'graphql/validation/validate';
import gql from 'graphql-tag';
import { typeSerializer } from 'apollo-federation-integration-testsuite';
import { buildMapsFromServiceList } from '../../../compose';
import federationDirectives from '../../../../directives';
import { UniqueFieldDefinitionNames } from '..';
import { ServiceDefinition } from '../../../types';
expect.addSnapshotSerializer(typeSerializer);
// simulate the first half of the composition process
function createDocumentsForServices(
serviceList: ServiceDefinition[],
): DocumentNode[] {
const { typeDefinitionsMap, typeExtensionsMap } = buildMapsFromServiceList(
serviceList,
);
return [
{
kind: Kind.DOCUMENT,
definitions: Object.values(typeDefinitionsMap).flat(),
},
{
kind: Kind.DOCUMENT,
definitions: Object.values(typeExtensionsMap).flat(),
},
];
}
describe('UniqueFieldDefinitionNames', () => {
let schema: GraphQLSchema;
// create a blank schema for each test
beforeEach(() => {
schema = new GraphQLSchema({
query: undefined,
directives: [...specifiedDirectives, ...federationDirectives],
});
});
describe('enforces unique field names for', () => {
it('object type definitions', () => {
const [definitions, extensions] = createDocumentsForServices([
{
typeDefs: gql`
type Product {
sku: ID!
}
`,
name: 'serviceA',
},
{
typeDefs: gql`
extend type Product {
sku: Int!
}
`,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
schema = extendSchema(schema, definitions, {
assumeValidSDL: true,
});
errors.push(
...validateSDL(extensions, schema, [UniqueFieldDefinitionNames]),
);
expect(errors).toHaveLength(1);
expect(errors[0].message).toMatch(
'Field "Product.sku" already exists in the schema.',
);
});
it('interface definitions', () => {
const [definitions, extensions] = createDocumentsForServices([
{
typeDefs: gql`
interface Product {
sku: ID!
}
`,
name: 'serviceA',
},
{
typeDefs: gql`
extend interface Product {
sku: String!
}
`,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
schema = extendSchema(schema, definitions, { assumeValidSDL: true });
errors.push(
...validateSDL(extensions, schema, [UniqueFieldDefinitionNames]),
);
expect(errors).toHaveLength(1);
expect(errors[0].message).toMatch(
'Field "Product.sku" already exists in the schema.',
);
});
it('input object definitions', () => {
const [definitions, extensions] = createDocumentsForServices([
{
typeDefs: gql`
input Product {
sku: ID
}
`,
name: 'serviceA',
},
{
typeDefs: gql`
extend input Product {
sku: String!
}
`,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
schema = extendSchema(schema, definitions, { assumeValidSDL: true });
errors.push(
...validateSDL(extensions, schema, [UniqueFieldDefinitionNames]),
);
expect(errors).toHaveLength(1);
expect(errors[0].message).toMatch(
'Field "Product.sku" already exists in the schema.',
);
});
});
describe('permits duplicate field names for', () => {
it('value types (identical object types)', () => {
const [definitions] = createDocumentsForServices([
{
typeDefs: gql`
type Product {
sku: ID!
color: String
}
`,
name: 'serviceA',
},
{
typeDefs: gql`
type Product {
sku: ID!
color: String
}
`,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
expect(errors).toHaveLength(0);
});
it('value types (identical interface types)', () => {
const [definitions] = createDocumentsForServices([
{
typeDefs: gql`
interface Product {
sku: ID!
color: String
}
`,
name: 'serviceA',
},
{
typeDefs: gql`
interface Product {
sku: ID!
color: String
}
`,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
expect(errors).toHaveLength(0);
});
it('value types (identical input types)', () => {
const [definitions] = createDocumentsForServices([
{
typeDefs: gql`
input Product {
sku: ID!
color: String
}
`,
name: 'serviceA',
},
{
typeDefs: gql`
input Product {
sku: ID!
color: String
}
`,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
expect(errors).toHaveLength(0);
});
it('object type definitions (non-identical, value types with type mismatch)', () => {
const [definitions] = createDocumentsForServices([
{
typeDefs: gql`
type Product {
sku: ID!
color: String
quantity: Int
}
`,
name: 'serviceA',
},
{
typeDefs: gql`
type Product {
sku: String!
color: String
quantity: Int!
}
`,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
expect(errors).toHaveLength(0);
});
it('object type definitions field and arguments with different type', () => {
const typeDefs = gql`
type Campaign implements Node {
identifier: String
event(identifier: String!): Event
}
`;
const [definitions] = createDocumentsForServices([
{
typeDefs,
name: 'serviceA',
},
{
typeDefs,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
expect(errors).toHaveLength(0);
});
});
it('object type definitions order does not impact diffing', () => {
const [definitions] = createDocumentsForServices([
{
typeDefs: gql`
type Order implements Node {
questions(answers: OrderAnswersInput): Questions
fees(answers: OrderAnswersInput): Fees
answers: [Answer]
}
`,
name: 'serviceA',
},
{
typeDefs: gql`
type Order implements Node {
questions(answers: OrderAnswersInput): Questions
answers: [Answer]
fees(answers: OrderAnswersInput): Fees
}
`,
name: 'serviceB',
},
]);
const errors = validateSDL(definitions, schema, [
UniqueFieldDefinitionNames,
]);
expect(errors).toHaveLength(0);
});
});