Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql-tag 3 that removes arbitrary string interpolation #748

Open
benasher44 opened this issue Apr 8, 2023 · 0 comments
Open

graphql-tag 3 that removes arbitrary string interpolation #748

benasher44 opened this issue Apr 8, 2023 · 0 comments

Comments

@benasher44
Copy link

benasher44 commented Apr 8, 2023

Hello! I see there is a comment to remove the ability to do arbitrary string interpolation in graphql-tag. I think the ecosystem has matured enough such that interpolating variables is no longer necessary (in most libraries, the ability to pass variables is readily available at the usage/call site). We have patched graphql-tag locally to remove the ability to do arbitrary string interpolation, which has been really helpful to force us to do the < 2 min of extra work to send a variables dict. It would be really great to remove this and publish a graphql-tag v3, creating safer graphql-tag usage.

I'd be happy to open the PR, but I wanted to open an issue first, since this would be a significant breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant