ESM CJS + Jest #1320
Merged
ESM CJS + Jest #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkisiela
force-pushed
the
feat/cjs-esm
branch
from
b7d6a88
to
a1bfd06
Compare
|
This looks awesome |
|
Might be nice to test with oldest supported version graphql v12 and latest |
|
@yaacovCR We have to set a range somewhere. Based on projects I know, the oldest version that is still in production is v0.13. We could test even v0.11, but there's no real need for it. |
|
Just noticed you left in v0.13, sounds great
…On Tue, Mar 31, 2020, 10:49 AM Kamil Kisiela ***@***.***> wrote:
@yaacovCR <https://github.com/yaacovCR> We have to set a range somewhere.
Based on projects I know, the oldest version that is still in production is
v0.13. We could test even v0.11, but there's no real need for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1320 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7LAYEPWD2LAS6DNPRAN5DRKH7GRANCNFSM4LXRSSQA>
.
|
This was referenced Mar 31, 2020
This was referenced Apr 1, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.