useQuery stays active causing refetch on resetStore

[riccoski]

Intended outcome:

Once the component containing the query has been unmounted the query should become in active therefore when resetting the store with client.resetStore() the query shouldn't be refetched.

Actual outcome:

The component has been unmounted however the query stays active and is refetched when calling client.resetStore()

How to reproduce the issue:

https://github.com/riccoski/reset-store-refetch-error.git

using the repo. If you click the reset store button you will see the second console log appear.
If you replace the AllPeople component with AllPeopleComponent which uses the query component it will do as expected and not refetch the query

Version

System:
OS: macOS 10.14.5
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.9.4 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Browsers:
Chrome: 75.0.3770.142
Firefox: 38.0.5
Safari: 12.1.1
npmPackages:
apollo-cache-inmemory: ^1.5.1 => 1.6.2
apollo-client: ^2.5.1 => 2.6.3
apollo-link: ^1.2.11 => 1.2.12
react-apollo: 2.5.3 => 2.5.3

[hwillson]

Thanks for reporting this @riccoski. The fix applied by #3273 also fixes this issue.