Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

@types peer dependencies are useless noise for flow/non-TS users, and not necessary anyway #3479

Open
jedwards1211 opened this issue Sep 9, 2019 · 2 comments
Labels
bug-upstream Bug confirmed to originate from a dependency

Comments

@jedwards1211
Copy link
Contributor

jedwards1211 commented Sep 9, 2019

I know TS is winning and I'm not opposed to it at all, but Flow is entrenched in my company's codebase. Would you accept a PR to remove these peer defs? They're not necessary since @types packages track the major/minor versions of the code packages. (Though tbh that was a bad decision, because sometimes breaking changes need to made to type defs regarding parameterization etc).

Obviously peer dep warnings are not blockers but we can't have an ever-growing list of peer dep warnings, because some of them can be very important, and noise like this gets in the way of noticing the ones that matter.

@jedwards1211 jedwards1211 changed the title @types peer dependencies are useless noise for flow users, and not necessary anyway @types peer dependencies are useless noise for flow/non-TS users, and not necessary anyway Sep 9, 2019
@hwillson
Copy link
Member

@jedwards1211 Please see the discussion in #3278. As soon as npm/cli#224 has been resolved, we'll get this adjusted. Thanks!

@hwillson hwillson added the bug-upstream Bug confirmed to originate from a dependency label Sep 14, 2019
@IAmVisco
Copy link

IAmVisco commented Sep 30, 2019

Just wanna give my 2 cents, @types libs are used by WebStorm for static analysis and code completion even for non-TS users, so sometimes it saves few clicks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-upstream Bug confirmed to originate from a dependency
Projects
None yet
Development

No branches or pull requests

3 participants