subscription: Ping message over graphql-ws protocol contains invalid payload #4852
Assignees
Labels
Comments
6 tasks
BrynCooke
pushed a commit
that referenced
this issue
Mar 26, 2024
Removes invalid payload on graphql-ws Ping message Fixes #4852 <!-- start metadata --> --- **Checklist** Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review. - [x] Changes are compatible[^1] - [x] Documentation[^2] completed - [x] Performance impact assessed and acceptable - Tests added and passing[^3] - [x] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
According to the
graphql-wsspec, the payload should be an object, but the router sends a string.Expected behavior
Send correct payload inside Ping
The text was updated successfully, but these errors were encountered: