Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation triggering in comments #118

Open
kyldvs opened this issue Oct 18, 2023 · 1 comment
Open

Schema validation triggering in comments #118

kyldvs opened this issue Oct 18, 2023 · 1 comment

Comments

@kyldvs
Copy link

kyldvs commented Oct 18, 2023

With the latest update paren support was added (which is a change I love and helps a ton btw), and now it's triggering in the generated example comment from @graphql-codegen.

image

Is this expected? I do actually need to add a user field, so I can make this go away, but this extension probably shouldn't trigger in comments (or at least not comments in generated code).

@alessbell
Copy link
Member

Hi @kyldvs, thanks for reporting this - I would also not expect that to error. I wrote a failing test, but I may not be able to come back to this for a week or two.

If anyone wants to pick this up in the meantime, it's up for grabs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants