-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apos3: document the need to include 'type' in the publicApiProjection and flag a missing type as a probable missing projection property. #3626
Comments
If That doesn't mean this isn't a legitimate ticket, but it might be recast as "document the need to include 'type' in the publicApiProjection and flag a missing |
A permission.can() call was made with a type that has no manager
when calling piece-type API
I changed the title accordingly. Perhaps you'd be interested in submitting PRs to |
Since Apostrophe requires it is there a reason we wouldn't ensure that it's there regardless of the option? I'm not sure why we'd require developers using the public api projection option to know about a core code requirement. |
That's a fair question. We could always add |
I agree with Alex, if it is always needed by the Apostrophe core we should not be specially aware about it. |
@boutell I think I'm witnessing the same behavior (console warning) without any custom projections but using the piece built in relation filter (think of articles filtered by a tag). The strange part is I'm seeing it only when not logged in. I can not confirm it 100% yet because I really lack time to set up a clean PoC. The debug shows me |
Totally possible, reproducible steps would be great
…On Thu, Jan 27, 2022 at 8:25 AM Miro Yovchev ***@***.***> wrote:
@boutell <https://github.com/boutell> I think I'm witnessing the same
behavior (console warning) without any custom projections but using the
piece built in relation filter (think of articles filtered by a tag). The
strange part is I'm seeing it only when not logged in. I can not confirm it
100% yet because I really lack time of set up a clean PoC. The debug shows
me can receives only `{ _id: xxx } object. Could it be an internal
routine (the built in relation type query)?
—
Reply to this email directly, view it on GitHub
<#3626 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAH27LKHIX32IM4BWVW4SLUYFBSZANCNFSM5MHT5VTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his
|
@boutell https://github.com/myovchev/apos-issue-3626 |
Thanks Miro, can we move that to a separate ticket? This issue was more
about Apostrophe helping to define better projections automatically.
…On Thu, Jan 27, 2022 at 9:49 AM Miro Yovchev ***@***.***> wrote:
@boutell <https://github.com/boutell>
https://github.com/myovchev/apos-issue-3626
Ccreate an article, assign a tag, create and navigate to an article page
type, click the tag, logout and look at the console logs.
—
Reply to this email directly, view it on GitHub
<#3626 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAH27OEOIY7ZRL7US4BR7LUYFLOBANCNFSM5MHT5VTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his
|
To Reproduce
Step by step instructions to reproduce the behavior:
Expected behavior
There should not be warning in this case.
Details
Version of Node.js:
Node v16.13.2. but reproduced on 12 too.
Server Operating System:
Reproduced on Windows, Linux, inside a Docker.
Workaround
Adding
type :1
topublicApiProjection
makes the warning disapear.The text was updated successfully, but these errors were encountered: