Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--insecure-http-parser is not allowed in NODE_OPTIONS #30

Closed
darrenahunter opened this issue Apr 26, 2020 · 1 comment
Closed

--insecure-http-parser is not allowed in NODE_OPTIONS #30

darrenahunter opened this issue Apr 26, 2020 · 1 comment

Comments

@darrenahunter
Copy link

fresh clone and install of thunderhub
running on node v12
yarn start fails with --insecure-http-parser is not allowed in NODE_OPTIONS

log from terminal follows

darrenhunter@192-168-1-9 thunderhub % yarn start
yarn run v1.22.4
$ cross-env NODE_OPTIONS='--insecure-http-parser' next start
/usr/local/bin/node: --insecure-http-parser is not allowed in NODE_OPTIONS
error Command failed with exit code 9.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
darrenhunter@192-168-1-9 thunderhub % code .
darrenhunter@192-168-1-9 thunderhub % node --version
v12.13.1

removing the NODE_OPTIONS from the start script works and next starts up

@apotdevin
Copy link
Owner

Hi, passing insecure-http-header is only available from node v12.15.0. (nodejs/node#27711 (comment))

Currently the only reason for passing it is because of the HodlHodl integration. There API seems to be passing invalid HTTP headers thus the need to add the param. Apart from the HodlHodl integration, everything else should work as expected if you remove this options from the start scripts.

Seeing as it's only for the HodlHodl integration will see if it makes sense to remove this from the start scripts and have another script to start with it.

Kodylow added a commit to Kodylow/thunderhub that referenced this issue Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants