Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in ModifierHeightWithText rule #25

Open
dimsuz opened this issue Jan 16, 2023 · 0 comments
Open

False positive in ModifierHeightWithText rule #25

dimsuz opened this issue Jan 16, 2023 · 0 comments

Comments

@dimsuz
Copy link
Collaborator

dimsuz commented Jan 16, 2023

This piece of code

Row(
  modifier = Modifier
    .height(IntrinsicSize.Min),
) {
  Text(
    modifier = Modifier
      .fillMaxHeight(),
    text = "Hello world",
  )
}

results in an error:

Composable uses "height" modifier and contains a Text child. Use heightIn(min = N.dp) instead [ModifierHeightWithText]

which is incorrect as this doesn't make sense for IntrinsicSize overload of height.

Exception is needed for this specific usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant