Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on ReusedModifierInstance when shadowing modifier #30

Open
BraisGabin opened this issue Aug 7, 2023 · 1 comment
Open

Comments

@BraisGabin
Copy link
Contributor

BraisGabin commented Aug 7, 2023

1.3.0 fixed a lot a false positives of ReusedModifierInstance. But there is one that it wasn't fixed yet. I created a test case to make it easy to reproduce it:

@Composable
fun Extra(a: @Composable (Modifier) -> Unit) {}
@Composable
fun Test(
  modifier: Modifier = Modifier, 
) {
  Column(modifier) {
    Extra { modifier ->
      Text("Hi", modifier)
    }
  }
}

The modifier that I'm using on Text is not the same that the one defined on Test.

@dimsuz
Copy link
Collaborator

dimsuz commented Aug 7, 2023

Thank you, I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants