Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider how users use offloadNone strategy while some filters block #2189

Open
idelpivnitskiy opened this issue Apr 13, 2022 · 1 comment

Comments

@idelpivnitskiy
Copy link
Member

idelpivnitskiy commented Apr 13, 2022

Existing approach is that if users specify offloadNone() execution strategy on the builder, we respect that and disable offloading. However, if they have a filter that for sure has blocking code, it will hurt users if we are silent about it. Consider the following improvement options:

  • still add offloading based on the filter chain requirements and log that the computed value is different from what was specified;
  • throw an exception describing what filter does not allow using offloadNone()
  • keep the offloading disabled, but warn users that they have a blocking code in the filter chain
@idelpivnitskiy
Copy link
Member Author

Logging is enhanced in #2224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant