mdc-utils: Make LoggerStringWriter thread friendly #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We have seen some flakyness in HttpMessageDiscardWatchdogServiceFilterTest that may be related to thread safety for the test log appender. Specifically, - The sink, a StringWriter, is globally shared so it can be reset by concurrently running tests. - The underlying StringWriter itself isn't thread safe and it's possible for it to be concurrent written to and read from. Modifications: - Make a new (thread safe) StringWriter for each thread. Based on the usage pattern for the LoggerStringWriter methods this should have the effect of having a unique writer per test. - Make a thread-safe proxy for the StringWriter so it's safe to write and read from concurrently.
daschl
reviewed
Dec 6, 2023
bryce-anderson
force-pushed
the
bl_anderson/flaky_HttpMessageDiscardWatchdogServiceFilterTest
branch
from
a32b203
to
a93e1e3
Compare
Your comment was spot on, and made it clear to me that the thread-local stuff is just a hack to preserve the static API that isn't worth it. So, I made |
bryce-anderson
force-pushed
the
bl_anderson/flaky_HttpMessageDiscardWatchdogServiceFilterTest
branch
from
a93e1e3
to
0b7c5c2
Compare
daschl
approved these changes
Dec 7, 2023
idelpivnitskiy
approved these changes
Dec 7, 2023
bryce-anderson
deleted the
bl_anderson/flaky_HttpMessageDiscardWatchdogServiceFilterTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have seen some flakyness in HttpMessageDiscardWatchdogServiceFilterTest that may be related to thread safety for the test log appender. Specifically,
Modifications:
Closes #2756. (hopefully)