Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DocumentURI.for to an initializer DocumentURI.init(for:) #1281

Closed
ahoppen opened this issue May 13, 2024 · 0 comments · Fixed by #1348
Closed

Change DocumentURI.for to an initializer DocumentURI.init(for:) #1281

ahoppen opened this issue May 13, 2024 · 0 comments · Fixed by #1348
Labels
good first issue Good for newcomers refactoring An internal refactoring of the codebase

Comments

@ahoppen
Copy link
Collaborator

ahoppen commented May 13, 2024

I don’t know why I went with a static method for on DocumentURI but the more Swifty way would be to have an initializer on DocumentURI.

rdar://126486535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring An internal refactoring of the codebase
Projects
None yet
Milestone
No milestone
1 participant
@ahoppen