New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when creating a DocumentURI from a URL with no scheme instead of hitting an assertion #1290

Open

ahoppen opened this issue May 14, 2024 · 1 comment

Labels

bug good first issue refactoring

Collaborator

ahoppen commented May 14, 2024

We should throw an error from here instead of crashing sourcekit-lsp by hitting an assertion failure.

sourcekit-lsp/Sources/LanguageServerProtocol/SupportTypes/DocumentURI.swift

Line 75 in 4bff560

    
           assert(self.storage.scheme != nil, "Received invalid URI without a scheme '\(self.storage.absoluteString)'")

ahoppen added bug refactoring labels

Collaborator Author

ahoppen commented May 14, 2024

Synced to Apple’s issue tracker as rdar://128036062

ahoppen added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment