New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name of plugin target to readable form #505
Change name of plugin target to readable form #505
Conversation
Arguably, there should be an additional parameter on the |
I'm on board with making the name look better in Xcode, though I'm not a huge fan of having a space in the file path. @neonichu do you have any thoughts, is this the best solution for improving the display name in Xcode? |
Yep, right now this is the only way. I do think it might be worthwhile to separately look into extending the |
This avoids having a space in the file path (by explicitly declaring a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this keeps the command-line verb the same, it looks like the change is really kept local to the package manifest, which then gets picked up by Xcode for the action name. Given that, I think this is fine to merge, especially since it doesn't bind us with source compatibility or anything else if we do discover problems down the road.
@swift-ci Please test |
Thanks for merging this! I hope to contribute in larger ways in the future! |
This PR updates the name of the "Generate Manual" plugin so that it appears in a more readable "command" form in the context menu in Xcode.
Before:
After:
Checklist