Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated stream channel functionality #220

Open
5 tasks
Lukasa opened this issue Jul 29, 2020 · 0 comments
Open
5 tasks

Remove deprecated stream channel functionality #220

Lukasa opened this issue Jul 29, 2020 · 0 comments
Labels
⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Milestone
2.0.0

Comments

@Lukasa
Copy link
Contributor

Lukasa commented Jul 29, 2020

In #214 we deprecated and replaced the old stream channel. When we do a 2.0.0 release, we should remove the old code paths, reducing binary size, compile time, and resolving some minor performance problems.

  • Remove the deprecated multiplexers and all tests that reference them.
  • Remove the genericism from HTTP2StreamChannel, as it’s no longer necessary.
  • Remove the extra code paths from MultiplexerAbstractChannel: it can concretely hold a single HTTP2StreamChannel
  • Remove the initializers and code paths in HTTP2StreamMultiplexer that are deprecated or no-longer called
  • Remove all deprecated pipeline helpers.
@Lukasa Lukasa added the ⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0 label Jul 29, 2020
@Lukasa Lukasa added this to the 2.0.0 milestone Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@Lukasa