Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incremental header compression mode. #85

Open
Lukasa opened this issue Apr 5, 2019 · 0 comments
Open

Remove incremental header compression mode. #85

Lukasa opened this issue Apr 5, 2019 · 0 comments
Labels
⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Milestone

Comments

@Lukasa
Copy link
Contributor

Lukasa commented Apr 5, 2019

When the HPACKEncoder was first written it was written to provide incremental header compression. This was enhanced later on in the development of v1 to provide one-shot header compression, which is what NIOHTTP2 uses today.

The presence of the incremental compression mode with beginEncoding/endEncoding forces some awkward compromises in the one-shot compression mode, which means that beginEncoding/endEncoding are forced to do weird extra allocations for no particularly good reason. Of course, this doesn't matter really, because we don't use the functions anyway, but they're part of the public interface to NIOHPACK and so cannot be changed right now.

In v2 we should just delete those functions. They're not useful, and cause more complexity than necessary.

@Lukasa Lukasa added the ⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0 label Apr 5, 2019
@Lukasa Lukasa added this to the 2.0.0 milestone Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Projects
None yet
Development

No branches or pull requests

1 participant