[Concurrency][SE-0434] Treat globally-isolated local captured functions as Sendable.
#73563
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndable`. Fix a bug where global isolation was not checked for globally-isolated local function captures. Such functions should be treated as 'Sendable' when captured.
|
@swift-ci please test macos |
simanerush
changed the title
Sendable.Sendable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where global isolation was not checked for globally-isolated local function captures. Such functions should be treated as
Sendablewhen captured.Resolves #73562.
Notes:
@Sendableis not allowed. If that is not the intended behavior, I can also fix that here.isSendable()function onAnyFunctionTypereturnedNotIsolatedfor an explicitly main-actor isolated local function, it would definitely be a nicer way to just use that function instead of checking for a presence of an attribute (as I currently do😵💫)