Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.* integration with gulp-plumber #64

Closed
liberat0r opened this issue Aug 21, 2014 · 8 comments
Closed

1.3.* integration with gulp-plumber #64

liberat0r opened this issue Aug 21, 2014 · 8 comments

Comments

@liberat0r
Copy link

After version 1.2.0 your plugin stopped working with gulp-plumber. When there is an SCSS error, the task breaks.

I really appreciate your work on this project.

Thank you.

@appleboy
Copy link
Owner

appleboy commented Oct 3, 2014

Hi @liberat0r

Please update to 1.3.2 and try again.

@liberat0r
Copy link
Author

Hello @appleboy,

I tried it but it still seems to have the same behavior. (not running after first error)

@appleboy
Copy link
Owner

appleboy commented Oct 8, 2014

@liberat0r I will try it again and give the sample config.

@liberat0r
Copy link
Author

@appleboy
Copy link
Owner

appleboy commented Oct 8, 2014

@liberat0r OK Thanks. I will take it.

@appleboy
Copy link
Owner

appleboy commented Oct 9, 2014

@liberat0r

According to gulpjs/gulp#259 (comment) and floatdrop/gulp-plumber#8 (comment) issues, please try the following config:

https://github.com/appleboy/html5-template-engine/blob/master/gulpfile.coffee#L51-L64

gulp.task 'compass', ->
  gulp.src paths.sass + '/**/*.scss'
    .pipe $.if !production, $.changed paths.css,
      extension: '.css'
    .pipe $.if !production, $.plumber
      errorHandler: (error) ->
        $.util.log $.util.colors.red error.message
        this.emit('end')
    .pipe $.compass
      css: paths.css
      sass: paths.sass
      image: paths.image
    .pipe $.if production, $.csso()
    .pipe gulp.dest paths.dist + '/assets/css/'

notice this.emit('end'); code.

@appleboy
Copy link
Owner

I add gulp-plumber example config on README.

@appleboy
Copy link
Owner

@liberat0r if you have the same problem, please reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants