Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] tcpreplay-edit recomputes IPv4 checksums unnecessarily #815

Closed
green-nsk opened this issue Jul 21, 2023 · 1 comment
Closed

[Bug] tcpreplay-edit recomputes IPv4 checksums unnecessarily #815

green-nsk opened this issue Jul 21, 2023 · 1 comment
Assignees
Projects

Comments

@green-nsk
Copy link

green-nsk commented Jul 21, 2023

Describe the bug

I think this line causes tcpreplay-edit to recompute all checksums for all IP packets unnecessarily. I noticed this because of a problem with recomputing UDP checksums, but in general I think it is 1) not allowing users to replay pcaps with errors 2) waste of time.

To Reproduce

Replay any pcap with errors in IP/UDP/TCP header checksums.

Expected behavior

I expect checksums to stay intact unless explicitly requested

Screenshots

N/A

System (please complete the following information):
All

Additional context

I tried fixing it, but seemingly unrelated tests keep breaking, so I figured I'm in over my head.

@green-nsk green-nsk changed the title [Bug] tcpreplay-edit recomputes IPv4 checksums are recomputed unnecessarily [Bug] tcpreplay-edit recomputes IPv4 checksums unnecessarily Jul 21, 2023
@fklassen fklassen self-assigned this Jun 8, 2024
@fklassen fklassen added this to To do in 4.5 via automation Jun 8, 2024
@fklassen
Copy link
Member

fklassen commented Jun 8, 2024

Fixed in PR #846

@fklassen fklassen closed this as completed Jun 8, 2024
4.5 automation moved this from To do to Done Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.5
Done
Development

No branches or pull requests

2 participants