Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Possible bug on tcprewrite version 4.4.4 for Ethernet layer #826

Closed
kYroL01 opened this issue Sep 18, 2023 · 2 comments
Closed

[Bug] Possible bug on tcprewrite version 4.4.4 for Ethernet layer #826

kYroL01 opened this issue Sep 18, 2023 · 2 comments
Assignees
Labels
Projects

Comments

@kYroL01
Copy link

kYroL01 commented Sep 18, 2023

Describe the bug
With tcprewrite version 4.4.4 I could not change the Linux cooked capture layer (SLL) to Ethernet layer, while it's working fine with version 4.3.1

To Reproduce
Steps to reproduce the behavior:

  1. Take a pcap with Linux cooked capture (DLT_LINUX_SLL 113)
  2. Run the command tcprewrite --dlt=enet --enet-dmac=12:ab:34:89:fb:10 --enet-smac=00:1e:79:9e:f8:00 -i old.pcap -o new.pcap
  3. Open the new.pcap with wireshark and you don't see the layers detected correctly

Screenshots
Version 4.4.4
ScreenShot_20230918155304

Version 4.3.1
ScreenShot_20230918155554

System (please complete the following information):

  • OS: Debian 11
  • Tcprewrite Version [e.g. 4.4.4]
@kYroL01 kYroL01 changed the title Possible bug on tcprewrite version 4.4.4 for Ethernet layer [Bug] Possible bug on tcprewrite version 4.4.4 for Ethernet layer Sep 18, 2023
@fklassen fklassen self-assigned this Jun 8, 2024
@fklassen fklassen added the bug label Jun 8, 2024
@fklassen fklassen added this to To do in 4.5 via automation Jun 8, 2024
@fklassen
Copy link
Member

fklassen commented Jun 8, 2024

This issue was solved in PR #873 as part of fix for bug #792.

@fklassen fklassen closed this as completed Jun 8, 2024
4.5 automation moved this from To do to Done Jun 8, 2024
@kYroL01
Copy link
Author

kYroL01 commented Jun 9, 2024

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
4.5
Done
Development

No branches or pull requests

2 participants