ci: Add sloppy /test command #33558
Merged
ci: Add sloppy /test command #33558
+55
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
skip-changelog
sharat87
requested review from
mohanarpit,
nidhi-nair,
yatinappsmith and
trishaanand
WalkthroughWalkthroughThe overall change to the pull request automation workflow includes implementing a new script for tag parsing from PR descriptions using Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
1
to
44
| function parseTags({core, context}) { | ||
| const body = context.payload.pull_request.body; | ||
|
|
||
| // "/ok-to-test" matcher. Takes precedence over the "/test" matcher. | ||
| const strictMatch = body.match(/\/ok-to-test tags="(.+?)"/)?.[1]; | ||
| if (strictMatch) { | ||
| return strictMatch; | ||
| return; | ||
| } | ||
|
|
||
| // "/test" matcher. | ||
| const allTags = require(process.env.GITHUB_WORKSPACE + "/app/client/cypress/tags.js").Tag; | ||
| const config = body.match(/^\/test\s+(.*)$/m)?.[1] ?? ""; | ||
| const concreteTags = []; | ||
|
|
||
| for (const [rawTag] of config.matchAll(/\w+/g)) { | ||
| console.log("Given: '" + rawTag + "'"); | ||
|
|
||
| // See if there is exact case-insensitive match. | ||
| const exactTagMatch = allTags.find(t => t.toLowerCase() === "@tag." + rawTag); | ||
| if (exactTagMatch) { | ||
| console.log("\tMatch found:", exactTagMatch); | ||
| concreteTags.push(exactTagMatch); | ||
| continue; | ||
| } | ||
|
|
||
| // See if there is a singular/plural match (very rudimentary language skills). | ||
| const countedMatch = allTags.find(t => t.toLowerCase().replace(/s$/, "") === "@tag." + rawTag.replace(/s$/, "")); | ||
| if (countedMatch) { | ||
| console.log("\tMatch found:", countedMatch); | ||
| concreteTags.push(countedMatch); | ||
| continue; | ||
| } | ||
|
|
||
| // More smart matchers? | ||
|
|
||
| // No match, fail. | ||
| core.setFailed("\tNo match found for tag:", rawTag); | ||
|
|
||
| // We still process the rest, so we report all invalid tags in the input in a single run. | ||
| } | ||
|
|
||
| return concreteTags.join(", "); | ||
| } |
There was a problem hiding this comment.
Consider adding unit tests for parseTags to ensure its robustness.
Would you like me to help by setting up some initial unit tests for this function?
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
yatinappsmith
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
/testcommand, without breaking the existing/ok-to-testhabits.This is a sloppy version of
/ok-to-test. Turns out humans are sloppy. So let's embrace the human. 🤯Example incantation:
The sloppy parser at work:
Of course, if a PR body contains
/ok-to-test, that takes precedence, and any/testis ignored.We're also moving the logic of parsing the tags to a separate Javascript file. It's still not in a form that's easily testable, perhaps, but I hope this is a start for us to get to a "unit-tested CI". ❤️